Skip to content

Fix setup-gradle step in build-docs action #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024

Conversation

austin-denoble
Copy link
Contributor

Problem

I added a new action and workflow for building and generating client reference docs. Upon running the workflow, I realized I forgot the /actions/ part of the setup-gradle action. 🤦‍♂️

https://github.com/pinecone-io/pinecone-java-client/actions/runs/9020304652/job/24785162144

Solution

Update the uses field for the Setup Gradle step to point at the proper external action.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Try re-running the action once it's pushed to main

Copy link
Contributor

@rohanshah18 rohanshah18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@austin-denoble austin-denoble merged commit 989176a into main May 9, 2024
@austin-denoble austin-denoble deleted the adenoble/fix-build-docs-action branch May 9, 2024 19:22
@austin-denoble austin-denoble restored the adenoble/fix-build-docs-action branch May 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants