Add additional list functions to reach parity with RESTful list requests #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With REST, we are currently able to list vectors without a prefix but with a pagination token. This is not the case with v1 of the pinecone-java-clinet. With this PR, we have added a function list with a pagination token and limit but no prefix.
2 tasks
rohanshah18
requested changes
May 16, 2024
There was a problem hiding this comment.
Thanks for taking time to create this PR. Would you please:
- add the same method to the AsyncIndex?
https://github.com/pinecone-io/pinecone-java-client/blob/main/src/main/java/io/pinecone/clients/AsyncIndex.java - add tests here for both Index and AsyncIndex methods:
https://github.com/pinecone-io/pinecone-java-client/blob/main/src/integration/java/io/pinecone/integration/dataPlane/ListEndpointTest.java
|
Absolutely! |
|
Done! |
|
FYI, |
|
@rasharab Sorry I was out all of this week for a company event but I'm more than happy to run the integration tests and release this PR if you still need it |
|
Please release it. Thank you! |
|
Would you please open the PR again so I can run the integration test, verify the correctness, and merge it in. |
|
Sorry, one of our engineers deleted our fork. :( |
|
annoyingly, had to re-create pr... |
|
Ok thanks, taking a look |
rohanshah18
pushed a commit
that referenced
this pull request
May 24, 2024
…sts #130 (#133) ## Problem #126 ## Solution With REST, we are currently able to list vectors without a prefix but with a pagination token. This is not currently available with v1 of the pinecone-java-client. With this PR, we have added a function list with a pagination token and limit but no prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#126
Solution
With REST, we are currently able to list vectors without a prefix but with a pagination token.
This is not currently available with v1 of the pinecone-java-client.
With this PR, we have added a function list with a pagination token and limit but no prefix.