Skip to content

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Jan 31, 2025

Problem

Add support to create sparse serverless index method

Solution

As a part of this PR, added following changes:

  1. add createSparseServelessIndex() that doesn't accept dimension and metric as compared to the traditional createServerlessIndex()
  2. removed a validation to check for values (part of vector) being null or empty at the time of upsert since values can be an empty array of floats for sparse vector
  3. metric is now optional for creating serverless index and will default to cosine for dense index
  4. added integration tests

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Added integration tests

@rohanshah18 rohanshah18 marked this pull request as ready for review January 31, 2025 21:58
@rohanshah18 rohanshah18 merged commit fc5f7c0 into rshah/release-candidate/2025-01 Feb 3, 2025
1 of 6 checks passed
@rohanshah18 rohanshah18 deleted the rshah/sparse-index branch February 3, 2025 16:25
rohanshah18 added a commit that referenced this pull request Feb 3, 2025
## Problem

Add support to create sparse serverless index method

## Solution

As a part of this PR, added following changes:
1. add createSparseServelessIndex() that doesn't accept dimension and
metric as compared to the traditional createServerlessIndex()
2. removed a validation to check for values (part of vector) being null
or empty at the time of upsert since values can be an empty array of
floats for sparse vector
3. metric is now optional for creating serverless index and will default
to cosine for dense index
4. added integration tests

## Type of Change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

## Test Plan

Added integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant