Skip to content

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Sep 25, 2025

Problem

  1. Integration tests have been failing
  2. submit-gradle job was failing because it used java 21 with incompatible gradle version.

Solution

  1. Fix flaky integration tests
  2. Add cleanup job that deletes all indexes after integration tests are completed (regardless of success/failure of the job)
  3. Update gradle version to 8.5 for all workflows

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Integration tests should run successfully

@rohanshah18 rohanshah18 changed the title Update gradle version and fix flaky tests Update gradle version, fix flaky integration tests, and add cleanup job Sep 29, 2025
@rohanshah18 rohanshah18 marked this pull request as ready for review September 29, 2025 20:32
@rohanshah18 rohanshah18 merged commit cd5e19f into main Sep 29, 2025
17 of 19 checks passed
@rohanshah18 rohanshah18 deleted the rshah/fix-ci branch September 29, 2025 20:34
pinecone.configureServerlessIndex(indexName, DeletionProtection.DISABLED, null, null);
}
Thread.sleep(5000);
pinecone.deleteIndex(indexName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small chance the index may not be deletable if it's stuck in an upgrading or stuck or something like that. It might be nice to add a try catch here and explicitly handle possible errors on delete to make sure the cleanup process continues to other indexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants