-
Notifications
You must be signed in to change notification settings - Fork 13
Add upsert(List<Vectors>, String namespace), Rename clients, add createIndexConnection() and createAsyncIndexConnection() #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/integration/java/io/pinecone/integration/dataPlane/pod/QueryErrorTest.java
Outdated
Show resolved
Hide resolved
src/integration/java/io/pinecone/integration/dataPlane/serverless/QueryErrorTest.java
Outdated
Show resolved
Hide resolved
src/integration/java/io/pinecone/integration/dataPlane/serverless/QueryErrorTest.java
Outdated
Show resolved
Hide resolved
src/integration/java/io/pinecone/integration/controlPlane/pod/ConfigureIndexTest.java
Show resolved
Hide resolved
@rohanshah18, @austin-denoble, does it make sense to combine your efforts on integration tests and we can review them together? If so, I'll focus my review on |
@ssmith-pc I wouldn't mind it in normal circumstances but since this is the last ticket for milestone 2 and to get the next release out v1.0.0.RC1, I'd like to merge this as it is. |
I'm definitely fine having you merge first and I'll rebase my work on top. Working on finishing up reviewing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, I really appreciate the renaming and the helper functions added to Pinecone
. This feels like it helps move us further along with our UX desires. I'm good to merge this in as is.
I've left some questions and concerns. I think we need to follow up as a group on handling upsert
.
src/integration/java/io/pinecone/integration/dataPlane/UpsertAndQueryServerlessTest.java
Show resolved
Hide resolved
src/integration/java/io/pinecone/integration/dataPlane/UpsertAndQueryServerlessTest.java
Outdated
Show resolved
Hide resolved
src/integration/java/io/pinecone/integration/dataPlane/UpsertAndQueryServerlessTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for getting the list vector upsert support in place. I've left some questions and comments but we can address those in follow-up PRs.
Problem
Solution
Firstly, we have added the support to upsert a list of vectors.
Example usage:
We have renamed the following clients and config classes:
Next, we have added createIndexConnection() and createAsyncIndexConnection() to Pinecone class to improve the usage:
Type of Change
Test Plan
I have added UpsertAndQueryTestServerlessTest to test both createIndexConnection() and createAsyncIndexConnection() methods. Furthermore, I have renamed existing dataplane tests for pod indexes by adding pod to the class name. I'll be working on adding more data plane tests using both index creation methods for serverless indexes as a part of my next PR.