Skip to content

Remove unused constants #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

Remove unused constants #350

merged 1 commit into from
Jun 4, 2024

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Jun 4, 2024 •
edited
Loading

Problem

I noticed there are a few constants defined that are not currently being used anywhere.

Solution

  • Search in codebase to confirm these are no longer in use.
  • Remove them.

Type of Change

  • Chore (cleanup dead code)

Test Plan

See tests still pass.

@jhamon jhamon requested a review from austin-denoble June 4, 2024 15:40
@jhamon jhamon marked this pull request as ready for review June 4, 2024 15:41
austin-denoble
austin-denoble approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jhamon jhamon merged commit a4a136a into main Jun 4, 2024
@jhamon jhamon deleted the jhamon/removing-unused-constants branch June 4, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-denoble austin-denoble austin-denoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamon @austin-denoble