Fix: PineconeGrpcFuture blocks during construction #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using grpc with async_req, the construction of a PineconeGrpcFuture would call _sync_state, which would do a blocking call to grpc_future.exception(...). This means that the async_reqs were all blocking in practice. We can fix it by checking if the future is still running and not doing any blocking calls when it is.
|
This makes a lot of sense; I didn't realize |
|
Seems like some of the unit tests are broken by this change. I'll need to do some follow-up before we can merge this in. |
|
I've fixed the unit test. |
|
This looks good; the integration tests are expected to fail due to your PR from fork not being able to read secrets from the repo. Thanks! |
1 task
jhamon
added a commit
that referenced
this pull request
May 20, 2025
## Problem A recent change submitted in PR #478 revealed some of the integration tests were not working as they should be working; some errors related to incorrect test setup were being masked. ## Solution Fix broken tests. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using grpc with
async_req=True, the construction of aPineconeGrpcFuturewould call_sync_state, which would do a blocking call togrpc_future.exception(...). This means that the async reqs were all blocking in practice.Describe the purpose of this change. What problem is being solved and why?
Solution
We can fix it by checking if the future is still running and not doing any blocking calls when it is.
Type of Change
Test Plan
How I tested it:
PineconeGrpcFuture().result()call instead.