Fix missing readline error on Windows #503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing
readline
dependency error when usinglist_models
function. Reported in #502Solution
This error was the result of the Cursor assistant putting some code into
pinecone/scripts/repl.py
that should only have gone intoscripts/repl.py
(and not been part of the package distribution).This wasn't caught in CI because:
readline
is included in our dev dependencies, which are installed in CI for testing purposes.readline
is part of the python standard library, so even though this reference was inadvertantly referenced, the presence of these import statements should not cause a problem on dev machines (mac) or CI (linux). However,readline
is not available for Windows which is why this error was occurring for the person who reported.Type of Change
Test Plan
list_models()
works in google colab (where dev dependencies are not present) (7.0.2.dev1)