-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add events page #628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
- Coverage 55.78% 55.61% -0.18%
==========================================
Files 68 68
Lines 4383 4393 +10
==========================================
- Hits 2445 2443 -2
- Misses 1768 1779 +11
- Partials 170 171 +1
Continue to review full report at Codecov.
|
This pull request introduces 2 alerts when merging b65ea84 into a26f169 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging cf6a3b6 into a26f169 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 5647ea8 into a26f169 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 44ce709 into a26f169 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging f3ddbd1 into 7eb8d81 - view on LGTM.com new alerts:
|
I append some patches to this PR, includes:
|
This pull request introduces 2 alerts when merging fd35fa1 into 7eb8d81 - view on LGTM.com new alerts:
|
@g1eny0ung Would you mind taking a look at the lgtm bot? Can you solve this? |
I viewed its warning notification several hours ago. its actually "used", just the variable definition not used. The reason I wanna keep it because it can help other people to understand what this code does if he wants to deep into it. As u can see, I already put a comment I suggest banning the bot from checking TS codes because the code has already been linted during development. |
I think maybe it is a little weird here because this is a table for events. Do you think it is better to use an Another thing is that the events are stored in database, they are records for the past. But the |
@yeya24 I think you're right. There is a feature I haven't come true is when clicking the detail button, it will jump to the experiment detail page, I wanna replace the events table in the detail page to an event detail panel. Replace this area to event detail which you selected. What do you think this way? |
Wow, that's much better! |
This pull request introduces 2 alerts when merging 7c9817d into 5dd0b86 - view on LGTM.com new alerts:
|
@yeya24 The feature of And this thing:
@fewdan will help us filter out the events of survival experiments. |
This pull request introduces 2 alerts when merging bffa717 into c4672de - view on LGTM.com new alerts:
|
@yeya24 For cases where the table will be narrow on a small screen. I add a patch commit bffa717. it will make the left area (which table in) in the detail page from 2/3 to 3/4. And also, now the sidebar will remember your last choice to initialize its initial width, mini or normal. You can toggle it to mini when your screen is small relatively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@cwen0 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: shonge <soog2008@hotmail.com>
What problem does this PR solve?
As the title.