Skip to content

titan_doc_8.0 #16837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 25, 2024
Merged

titan_doc_8.0 #16837

merged 16 commits into from
Mar 25, 2024

Conversation

tonyxuqqi
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@tonyxuqqi
titan_doc_8.0
7e366c3 
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
@tonyxuqqi tonyxuqqi requested a review from Connor1996 March 14, 2024 04:34
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2024
v01dstar
v01dstar approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@v01dstar v01dstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2024

@v01dstar: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Connor1996
Connor1996 reviewed Mar 14, 2024
View reviewed changes
Connor1996
Connor1996 reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blob cache size 相关的描述也顺带改一下？

@Oreoxmt Oreoxmt requested a review from qiancai March 14, 2024 07:19
@Oreoxmt Oreoxmt added the v8.0 This PR/issue applies to TiDB v8.0. label Mar 14, 2024
@qiancai qiancai self-assigned this Mar 14, 2024
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 14, 2024
@tonyxuqqi
update
e52ed01 
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2024
@tonyxuqqi @Connor1996
Update storage-engine/titan-configuration.md
b938ad0 
Co-authored-by: Connor <zbk602423539@gmail.com>
qiancai
qiancai reviewed Mar 15, 2024
View reviewed changes
qiancai
qiancai reviewed Mar 15, 2024
View reviewed changes
tonyxuqqi and others added 6 commits March 15, 2024 13:55
@tonyxuqqi @qiancai
Update storage-engine/titan-configuration.md
3142128 
Co-authored-by: Grace Cai <qqzczy@126.com>
@tonyxuqqi @qiancai
Update storage-engine/titan-configuration.md
445b048 
Co-authored-by: Grace Cai <qqzczy@126.com>
@tonyxuqqi @qiancai
Update storage-engine/titan-configuration.md
ee71b11 
Co-authored-by: Grace Cai <qqzczy@126.com>
@tonyxuqqi @qiancai
Update dynamic-config.md
b748d53 
Co-authored-by: Grace Cai <qqzczy@126.com>
@tonyxuqqi @qiancai
Update tikv-configuration-file.md
d1a6479 
Co-authored-by: Grace Cai <qqzczy@126.com>
@tonyxuqqi @qiancai
Update tikv-configuration-file.md
f0048c7 
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai mentioned this pull request Mar 16, 2024
Merged
18 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 16, 2024
qiancai
qiancai reviewed Mar 16, 2024
View reviewed changes
@v01dstar
Copy link
Contributor

Do not merge this, until tikv/tikv#16460 and tikv/tikv#16517 are merged. If those 2 PRs do not get merged into 8.0 then we should add the changes' documentation to a later release.

Connor1996
Connor1996 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 20, 2024

@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tonyxuqqi
update
bf46fa1 
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
qiancai
qiancai reviewed Mar 21, 2024
View reviewed changes
qiancai
qiancai reviewed Mar 21, 2024
View reviewed changes
qiancai
qiancai reviewed Mar 21, 2024
View reviewed changes
tonyxuqqi
tonyxuqqi commented Mar 21, 2024
View reviewed changes
Copy link
Contributor Author

@tonyxuqqi tonyxuqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 21, 2024
lilin90
lilin90 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-21 01:29:58.082780418 +0000 UTC m=+1513025.105026807: ☑️ agreed by qiancai.
  • 2024-03-22 06:14:23.996399123 +0000 UTC m=+1616491.018645504: ☑️ agreed by lilin90.

qiancai
qiancai reviewed Mar 22, 2024
View reviewed changes
@qiancai
Copy link
Collaborator

qiancai commented Mar 25, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit d65eeea into pingcap:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@lilin90 lilin90 lilin90 approved these changes

+1 more reviewer

@v01dstar v01dstar v01dstar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@qiancai qiancai

Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.0 This PR/issue applies to TiDB v8.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tonyxuqqi @v01dstar @qiancai @Connor1996 @lilin90 @Oreoxmt