Skip to content

sql-statement: calibrate resource support workload #13270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 23, 2023
Merged

sql-statement: calibrate resource support workload #13270

merged 9 commits into from
Apr 23, 2023

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Apr 18, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

as tittle

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd self-assigned this Apr 18, 2023
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Apr 18, 2023
@hfxsd hfxsd requested a review from HuSharp April 18, 2023 13:56
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2023
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v7.1 This PR/issue applies to TiDB v7.1. labels Apr 18, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 18, 2023
@hfxsd hfxsd requested a review from lance6716 April 18, 2023 13:58
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2023
@hfxsd hfxsd requested review from songrijie, glorv and Oreoxmt and removed request for lance6716 April 18, 2023 14:07
glorv
glorv reviewed Apr 19, 2023
View reviewed changes
sql-statements/sql-statement-calibrate-resource.md Outdated
The `CALIBRATE RESOURCE` statement is used to estimate and output the ['Request Unit (RU)`](/tidb-resource-control#what-is-request-unit-ru) capacity of the current cluster.
The `CALIBRATE RESOURCE` statement is used to estimate and output the ['Request Unit (RU)`](/tidb-resource-control#what-is-request-unit-ru) capacity of the current cluster. TiDB provides two methods for estimation:

- Method 1: view the capacity within a specified time window depending on the actual workload. The following constraints apply to improve the accuracy of the estimation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Method 1: view the capacity within a specified time window depending on the actual workload. The following constraints apply to improve the accuracy of the estimation:
- Method 1: estimate the capacity based on the actual workload during a specified time window. The following constraints apply to improve the accuracy of the estimation:

HuSharp
HuSharp reviewed Apr 19, 2023
View reviewed changes
@hfxsd @HuSharp
Apply suggestions from code review
38e2272 
Co-authored-by: Hu# <ihusharp@gmail.com>
hfxsd
hfxsd commented Apr 20, 2023
View reviewed changes
sql-statements/sql-statement-calibrate-resource.md Outdated
- You have `SUPER` or `RESOURCE_GROUP_ADMIN` privilege.
- You have the `SELECT` privilege for all tables in the `METRICS_SCHEMA` schema.

## Parameters
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Parameters
## Estimation methods

hfxsd
hfxsd commented Apr 20, 2023
View reviewed changes
hfxsd
hfxsd commented Apr 20, 2023
View reviewed changes
songrijie
songrijie reviewed Apr 20, 2023
View reviewed changes
songrijie
songrijie reviewed Apr 20, 2023
View reviewed changes
songrijie
songrijie approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@hfxsd @songrijie
Apply suggestions from code review
3a4d747 
Co-authored-by: Roger Song <roger.song@pingcap.com>
@HuSharp HuSharp mentioned this pull request Apr 20, 2023
Merged
15 tasks
HuSharp
HuSharp approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Oreoxmt
Oreoxmt approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 23, 2023
@hfxsd @Oreoxmt
Apply suggestions from code review
1437d97 
Co-authored-by: Aolin <aolinz@outlook.com>
@hfxsd hfxsd added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 23, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented Apr 23, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 1437d97

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit 87b58c7 into pingcap:master Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv left review comments

@songrijie songrijie songrijie approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

+1 more reviewer

@HuSharp HuSharp HuSharp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hfxsd hfxsd

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hfxsd @ti-chi-bot @glorv @songrijie @HuSharp @Oreoxmt