-
Notifications
You must be signed in to change notification settings - Fork 704
sql: add a note about FULLTEXT
#17876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So we support |
Note that these pages should have a note about
Note that the "CREATE INDEX" page already has a complete note about this: "TiDB supports parsing the Note that |
@kennytm looks like "USING" for index type is missing from the EBNF for "CREATE TABLE"? |
Note that |
Not that |
Maybe we should also add a note about the (meaningless) |
Co-authored-by: Daniël van Eeden <github@myname.nl>
OK, updated. |
I think the IndexOption of the create table statement page should be changed to:
|
Looks like these pages reference |
@dveeden If any EBNF references If you want a hyperlink it should go to https://docs.pingcap.com/tidb/stable/sql-statement-alter-index. |
Co-authored-by: Lilian Lee <lilin@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
sql: Update EBNF related to indexing
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?