Skip to content

Extend DDL/MDL info #20329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 2, 2025
Merged

Extend DDL/MDL info #20329

merged 7 commits into from
Apr 2, 2025

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Feb 19, 2025

What is changed, added or deleted? (Required)

https://docs.pingcap.com/tidb/stable/metadata-lock#observability gives some useful info, but it is hard to find and this table lacks documentation.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2025
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2025
dveeden and others added 3 commits February 20, 2025 05:33
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd self-assigned this Feb 21, 2025
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions

| job_id | bigint | NO | PRI | NULL | |
| db_name | longtext | YES | | NULL | |
| table_name | longtext | YES | | NULL | |
| query | longtext | YES | | NULL | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify the different fields as well?
Looking at https://docs.pingcap.com/tidb/stable/metadata-lock/#observability the query is the DDL, and the session ID and SQL_DIGESTS are from the blocking DML queries.

Also there is a mismatch between the lower case names in this table and the UPPER CASE field names in https://docs.pingcap.com/tidb/stable/metadata-lock/#observability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the other doc as well to match the v8.5.1 behavior.

| SQL_DIGESTS | varchar(5) | YES | | NULL | |
+-------------+-----------------+------+------+---------+-------+
7 rows in set (0.00 sec)
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have an example of where it is used, or at least a backlink to https://docs.pingcap.com/tidb/stable/metadata-lock/#observability ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 8 we link to that information.

Copy link

ti-chi-bot bot commented Mar 18, 2025

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM with some suggestions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden dveeden requested review from bb7133 and CbcWestwolf March 19, 2025 08:58
@hfxsd hfxsd requested a review from lilin90 April 2, 2025 06:26
@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 2, 2025
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 2, 2025
Copy link

ti-chi-bot bot commented Apr 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-20 01:10:52.598374225 +0000 UTC m=+1096494.994596282: ☑️ agreed by hfxsd.
  • 2025-04-02 06:49:19.540872051 +0000 UTC m=+1634253.225108147: ☑️ agreed by lilin90.

@hfxsd hfxsd added the lgtm label Apr 2, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Apr 2, 2025

/approve

Copy link

ti-chi-bot bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 2, 2025
@ti-chi-bot ti-chi-bot bot merged commit f108274 into pingcap:master Apr 2, 2025
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20705.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 2, 2025
16 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 2, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2025
@lilin90 lilin90 mentioned this pull request Apr 7, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants