-
Notifications
You must be signed in to change notification settings - Fork 705
Premium V1 change #21790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premium V1 change #21790
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @qqqdan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the documentation for TiDB Cloud Premium by removing various sections from its Table of Contents. The changes indicate a focused effort to refine the content, likely by removing features or topics that are no longer relevant or have been deprecated for the 'Premium V1' offering, ensuring the documentation accurately reflects the current product scope.
Highlights
- Documentation Restructuring: Several documentation sections related to TiDB Cloud Premium features have been removed from the Table of Contents.
- Feature Documentation Removal: Specific documentation for 'Branch' management, 'Export Data from TiDB Cloud', 'Cluster Events', 'Garbage Collection (GC)', 'Upgrade a TiDB Cluster', 'Import Local Files', and the entire 'Vector Search' section have been removed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes several sections from the TOC-tidb-cloud-premium.md
file, likely as part of a content restructuring. The deletions are clean and do not introduce any formatting issues. I've added one minor comment regarding a capitalization inconsistency in a deleted line for future reference.
- [Overview](/vector-search/vector-search-integration-overview.md) | ||
- AI Frameworks | ||
- [LlamaIndex](/vector-search/vector-search-integrate-with-llamaindex.md) | ||
- [Langchain](/vector-search/vector-search-integrate-with-langchain.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this line is being removed, please note for future reference that product names should be capitalized correctly for consistency, as per the style guide.1 The proper name is 'LangChain', not 'Langchain'.
- [Langchain](/vector-search/vector-search-integrate-with-langchain.md) | |
- [LangChain](/vector-search/vector-search-integrate-with-langchain.md) |
Style Guide References
Footnotes
-
Use consistent terminology. This includes correct capitalization of product and brand names. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?