Skip to content

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Sep 23, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Sep 23, 2025
@hfxsd hfxsd requested a review from qiancai September 23, 2025 02:43
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Sep 23, 2025
@hfxsd hfxsd added area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. labels Sep 23, 2025
@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 23, 2025
@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/develop This PR relates to the area of TiDB App development. labels Sep 23, 2025
@hfxsd hfxsd changed the base branch from master to release-8.5 September 23, 2025 02:44
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2025
Copy link

ti-chi-bot bot commented Sep 23, 2025

@ginkgoch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Summary of Changes

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines and expands the documentation across TiDB Cloud and TiDB Self-Managed offerings. The changes aim to provide users with more comprehensive, accurate, and structured information on new features, best practices, and operational guidance. The updates span from detailed API and SQL function explanations to practical deployment and performance tuning advice, ensuring the documentation remains current and highly usable for developers and administrators alike.

Highlights

  • Documentation Restructuring and Expansion: The pull request introduces significant restructuring and expansion of the documentation, particularly for TiDB Cloud (Starter, Essential, and Dedicated tiers) and TiDB Self-Managed. This includes new Table of Contents files and reorganization of existing ones to improve navigation and clarity.
  • New Feature Documentation: Documentation for several new features has been added or expanded, such as C# language support, advanced multi-column index optimization, and detailed batch processing capabilities (Pipelined DML, non-transactional DML). Specific sections for Data Service and Vector Search have also been introduced with BETA tags.
  • Improved Monitoring and Performance Tuning Guides: The monitoring and performance tuning sections have been enhanced with new alert subscription options, details on TiDB Cloud Clinic, and new resource allocation optimization guides (Resource Manager, TiDB Node Group). The EXPLAIN ANALYZE output interpretation has also been refined.
  • Updated Compatibility and Best Practices: Compatibility matrices for TiDB Data Migration (DM) and Backup & Restore (BR) have been updated to reflect the latest versions. New best practices documents cover handling millions of tables in SaaS multi-tenant scenarios, optimizing multi-column indexes, and updated guidance for auto-increment/auto-random ID management.
  • System Configuration and Tooling Enhancements: Detailed instructions for system configuration checks, including disabling swap and configuring firewalls, have been added. Updates to various tool-specific documentation (Dumpling, TiDB Lightning, TiUP) and command-line flag descriptions provide more comprehensive guidance.
  • Codebase and Dependency Updates: The .lycheeignore file has been updated to ignore numerous new external URLs, and the OWNERS file reflects changes in approver roles. Internal links within the documentation have been updated to point to the correct release-8.5 branch where applicable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds release notes for September 23, 2025. The changes are well-written and clear. I've made a couple of minor suggestions to fix some typos and formatting for better readability. Overall, great work!

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hfxsd hfxsd removed the contribution This PR is from a community contributor. label Sep 23, 2025
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2025
Copy link

ti-chi-bot bot commented Sep 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-23 03:30:20.317246612 +0000 UTC m=+327430.387740284: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd hfxsd added the lgtm label Sep 23, 2025
@hfxsd
Copy link
Collaborator Author

hfxsd commented Sep 23, 2025

/approve

Copy link

ti-chi-bot bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 227722d into pingcap:release-8.5 Sep 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants