-
Notifications
You must be signed in to change notification settings - Fork 26
[DNM] hack pd client to support basic keyspace #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @3AceShowHand, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a minor but important defensive programming change to the DDL history update logic. It adds a nil check to prevent potential runtime panics that could occur if database information is unexpectedly missing during schema DDL processing. This improves the overall stability of the system's DDL handling. The title "[DNM] hack pd client to support basic keyspace" appears to be a placeholder or refers to a broader, uncommitted scope, as the current change is focused solely on DDL history robustness.
Highlights
- Robustness Improvement: Implemented a nil check within updateDDLHistoryForSchemaDDL to prevent potential panics when accessing databaseInfo, ensuring safer handling of DDL events.
- DDL History Update Logic: Enhanced the DDL history update mechanism for schema DDLs by explicitly checking for the existence of database information before processing associated tables.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a nil-check in updateDDLHistoryForSchemaDDL
to prevent a potential panic when the database information is not found. While this is a good defensive measure, the current implementation of returning nil
could lead to incorrect DDL history tracking. My review includes a suggestion to align the behavior with other similar functions and ensure the DDL history is correctly updated.
9c4df1f
to
8c93e66
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
209a9db
to
f92d8d1
Compare
c0b78a1
to
2b4ba12
Compare
key := newMatchKey(entry) | ||
if state.matcher.unmatchedValue != nil { | ||
if _, exists := state.matcher.unmatchedValue[key]; exists { | ||
log.Warn("receive a COMMITTED entry while there is still unmatched prewrite on the same key", | ||
zap.Uint64("regionID", regionID), | ||
zap.String("key", hex.EncodeToString(entry.GetKey())), | ||
zap.Uint64("startTs", entry.GetStartTs()), | ||
zap.Uint64("commitTs", entry.GetCommitTs())) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code for a quick test? Should I pick to my branch ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for test, no need to pick.
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
@3AceShowHand: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note