kafka.go: Refine log #778
Merged
kafka.go: Refine log #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log fatal instead of panic(err), so user can know what really happen instead of like drainer restart by some unknown reason before check stderr.
kennytm
reviewed
Oct 22, 2019
yes |
|
/rebuild |
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/build |
suzaku
previously approved these changes
Oct 23, 2019
before update will:
./tools/check/check-tidy.sh
go: downloading gopkg.in/stretchr/testify.v1 v1.4.0
github.com/pingcap/tidb-binlog/drainer imports
github.com/pingcap/tidb/store/tikv imports
github.com/twinj/uuid tested by
github.com/twinj/uuid.test imports
gopkg.in/stretchr/testify.v1/assert: go.mod has non-....v1 module path "github.com/stretchr/testify" at revision v1.4.0
make: *** [tidy] Error 1
july2993
force-pushed
the
hjh/kafka_log
branch
from
d4065a8
to
acf7269
Compare
|
/run-all-tests |
|
/build |
|
/run-all-tests |
july2993
added
needs-cherry-pick-release-3.0
and removed
needs-cherry-pick-release-3.0
labels
try drop dep of: go: github.com/go-critic/go-critic@v0.0.0-20181204210945-ee9bf5809ead: invalid pseudo-version: does not match version-control timestamp (2019-02-10T22:04:43Z)
july2993
force-pushed
the
hjh/kafka_log
branch
from
1304981
to
98ad968
Compare
july2993
commented
Oct 29, 2019
| @@ -65,8 +65,7 @@ func InitLogger(level string, file string) error { | |||
| cfg := &log.Config{ | |||
| Level: level, | |||
| File: log.FileLogConfig{ | |||
| Filename: file, | |||
| LogRotate: true, | |||
There was a problem hiding this comment.
no any affect field in older version and is removed now.
|
/run-all-tests |
|
/run-all-tests |
|
@july2993 merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Oct 29, 2019
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Oct 29, 2019
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Oct 29, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
refine log.
What is changed and how it works?
log fatal instead of panic(err), so user can know what really happen
instead of like drainer restart by some unknown reason before check
stderr.
Check List
Tests