Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add drop column, rename column/index for incompatible ddl changes #751

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Oct 31, 2023

What problem does this PR solve?

Issue Number: ref #596 pingcap/tiflow#9850

What is changed and how it works?

  • add drop column
  • add rename column
  • add rename index
  • regard DropDatabase,DropTable,DropIndex,RenameTable,TruncateTable,DropSchema,DropTablePartition,TruncateTablePartition as incompatible ddls

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested a review from jiyfhust October 31, 2023 07:15
@GMHDBJD GMHDBJD changed the title update add drop column, rename column/index for incompatible ddl changes Oct 31, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 31, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 31, 2023

/run-unit-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/binlog-filter/filter.go Outdated Show resolved Hide resolved
Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichunzhu, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 07:34:38.272382312 +0000 UTC m=+2938475.859492458: ☑️ agreed by lichunzhu.
  • 2023-10-31 07:34:54.20139536 +0000 UTC m=+2938491.788505505: ✖️🔁 reset by GMHDBJD.
  • 2023-10-31 07:40:04.016302574 +0000 UTC m=+2938801.603412718: ☑️ agreed by lichunzhu.

@GMHDBJD GMHDBJD merged commit a020d2c into pingcap:master Oct 31, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants