Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binlog filter ddl event type #766

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jan 19, 2024

What problem does this PR solve?

Issue Number: close #767 ref pingcap/tiflow#10511

What is changed and how it works?

Add some ddl event type to binlog filter package.

Check List

Tests

  • Unit test
  • No code

Code changes

  • Has exported variable/fields change

Side effects

Related changes

@asddongmen asddongmen changed the title add filter ddl event type add binlog filter ddl event type Jan 19, 2024
@asddongmen asddongmen self-assigned this Jan 19, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 19, 2024
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-19 06:02:41.221523693 +0000 UTC m=+508602.785821398: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3600af4 into pingcap:master Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more ddl event type to binlog filter package.
2 participants