Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb_constraint_check_in_place_pessimistic should not be global scope, and should not affect internal sessions #38766

Closed
ekexium opened this issue Oct 31, 2022 · 2 comments · Fixed by #38767
Closed

tidb_constraint_check_in_place_pessimistic should not be global scope, and should not affect internal sessions #38766

ekexium opened this issue Oct 31, 2022 · 2 comments · Fixed by #38767
Labels
affects-6.3 affects-6.4 severity/critical sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@ekexium
Copy link
Contributor

ekexium commented Oct 31, 2022 •
edited
Loading

Enhancement

Changing this variable can lead to unexpected results. Internals sessions shouldn't be affected by it as well, e.g. the imeplementation of get_lock() depends on tidb_contraint_check_in_place_pessimistic=1to work.
We should only allow sessions that are aware of its effects use it.
@ekexium ekexium added the type/enhancement The issue or PR belongs to an enhancement. label Oct 31, 2022
@ekexium ekexium mentioned this issue Oct 31, 2022
Merged
12 tasks
@sticnarf
Copy link
Contributor

Is it the exact reason of the inconsistency in system tables?

@ekexium
Copy link
Contributor Author

ekexium commented Oct 31, 2022

Is it the exact reason of the inconsistency in system tables?

Well I haven't investigated it. It might be. After the fix we can see if it still happens since it is said to be reproducible.

@ekexium ekexium added type/bug The issue is confirmed as a bug. severity/major labels Nov 4, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 labels Nov 4, 2022
@ekexium ekexium removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 labels Nov 4, 2022
ti-chi-bot pushed a commit that referenced this issue Nov 7, 2022
@ekexium
txn: tidb_constraint_check_in_place_pessimistic should not be global …
21d6190 
…scoped (#38767)

close #38766
@ti-chi-bot ti-chi-bot mentioned this issue Nov 7, 2022
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Nov 7, 2022
@ekexium @ti-chi-bot
txn: tidb_constraint_check_in_place_pessimistic should not be global …
4885377 
…scoped (pingcap#38767)

close pingcap#38766
@ekexium ekexium added sig/transaction SIG:Transaction severity/critical and removed type/enhancement The issue or PR belongs to an enhancement. severity/major labels Nov 7, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 labels Nov 7, 2022
@ekexium ekexium changed the title tidb_constraint_check_in_place_pessimistic should not be global scope tidb_constraint_check_in_place_pessimistic should not be global scope, and should not affect internal sessions Nov 7, 2022
ti-chi-bot added a commit that referenced this issue Nov 7, 2022
@ti-chi-bot
txn: tidb_constraint_check_in_place_pessimistic should not be global …
2b88090 
…scoped (#38767) (#38922)

close #38766
@cfzjywxk cfzjywxk mentioned this issue Nov 8, 2022
Merged
14 tasks
@ekexium ekexium added affects-6.3 and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 labels Nov 16, 2022
@cfzjywxk cfzjywxk mentioned this issue Dec 5, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.3 affects-6.4 severity/critical sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

txn: tidb_constraint_check_in_place_pessimistic should not be global scoped ekexium/tidb
4 participants
@VelocityLight @sticnarf @ekexium @ti-chi-bot