Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A better error handling on backup & restore. #47656

Closed
3pointer opened this issue Oct 16, 2023 · 2 comments · Fixed by #48646
Closed

A better error handling on backup & restore. #47656

3pointer opened this issue Oct 16, 2023 · 2 comments · Fixed by #48646
Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. report/customer Customers have encountered this bug. severity/major type/enhancement The issue or PR belongs to an enhancement.

Comments

@3pointer
Copy link
Contributor

Enhancement

Some unpredictable errors from storage appear from time to time. we cannot rely on the allow-error-list to determine whether the error can be retry or not. So I think we should use block-list instead.
@3pointer 3pointer added the type/enhancement The issue or PR belongs to an enhancement. label Oct 16, 2023
@3pointer 3pointer mentioned this issue Oct 16, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2023
@3pointer
br: retry import sst files on invalidPart error (#47584)
5203ebb 
ref #47656
This was referenced Oct 16, 2023
Closed
Closed
@jebter jebter added the component/br This issue is related to BR of TiDB. label Oct 19, 2023
3pointer added a commit to 3pointer/tidb that referenced this issue Oct 20, 2023
@3pointer
br: retry import sst files on invalidPart error (pingcap#47584)
e5fa802 
ref pingcap#47656
@3pointer 3pointer mentioned this issue Oct 20, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 20, 2023
@3pointer
br: retry import sst files on invalidPart error (#47584) (#47858)
766e0c6 
ref #47656
@3pointer 3pointer mentioned this issue Nov 16, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 8, 2023
@3pointer
br: refactor error handle mechanism to tolerant unexpect kv errors. (#…
6c30c6e 
…48646)

close #47656
This was referenced Dec 8, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@ti-chi-bot
br: refactor error handle mechanism to tolerant unexpect kv errors. (#…
eacc493 
…48646) (#49276)

close #47656
@ti-chi-bot ti-chi-bot mentioned this issue Feb 4, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 4, 2024
@ti-chi-bot
br: refactor error handle mechanism to tolerant unexpect kv errors. (#…
2ca45ac 
…48646) (#50951)

close #47656
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
@ti-chi-bot
br: refactor error handle mechanism to tolerant unexpect kv errors. (#…
532100f 
…48646) (#49274)

close #47656
@JasonWu0506
Copy link

@3pointer please check whether this issue happened in v6.1？ if yes, please add a label "affects-6.1". thanks

@Leavrth Leavrth mentioned this issue Mar 28, 2024
Closed
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this issue Apr 2, 2024
@3pointer @wuhuizuo
br: retry import sst files on invalidPart error (pingcap#47584)
b566ecc 
ref pingcap#47656
@Leavrth Leavrth mentioned this issue Apr 26, 2024
Closed
@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. report/customer Customers have encountered this bug. severity/major type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: refactor error handle mechanism to tolerant unexpect kv errors. 3pointer/tidb
6 participants
@jebter @3pointer @Leavrth @seiya-annie @ti-chi-bot @JasonWu0506