Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor cache implement for function regexp_substr #49583

Closed
Tracked by #49464
lcwangchao opened this issue Dec 19, 2023 · 0 comments · Fixed by #49584
Closed
Tracked by #49464

refactor cache implement for function regexp_substr #49583

lcwangchao opened this issue Dec 19, 2023 · 0 comments · Fixed by #49584
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

Enhancement

see #49464

regexp_substr caches some intermediate regexp.Regexp inside the function when some args are constant. Some issues for the current implement:

  1. The cache logic is coupled with plan cahe, and it is hard to say the function is stateless.
  2. When plan cahe is enabled, we cannot cache the object regexp.Regexp some times. For example, when the regex pattern is from the variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant