Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require no error in TestAdjustBlockSize #52277

Closed
lyzx2001 opened this issue Apr 1, 2024 · 1 comment · Fixed by #52278
Closed

require no error in TestAdjustBlockSize #52277

lyzx2001 opened this issue Apr 1, 2024 · 1 comment · Fixed by #52278
Assignees
@lyzx2001
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lyzx2001
Copy link
Contributor

lyzx2001 commented Apr 1, 2024

Enhancement

The dial tcp 127.0.0.1:10080: connect: connection refuse error checked in test TestAdjustBlockSize has been tested by TestAdjustConnectRefused. We can remove this check.
@lyzx2001 lyzx2001 added the type/enhancement The issue or PR belongs to an enhancement. label Apr 1, 2024
@lyzx2001
Copy link
Contributor Author

lyzx2001 commented Apr 1, 2024

/assign @lyzx2001

@lyzx2001 lyzx2001 mentioned this issue Apr 1, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 1, 2024
@lyzx2001
lightning: remove error check in TestAdjustBlockSize (#52278)
7c6241f 
close #52277
imalasong pushed a commit to imalasong/tidb that referenced this issue Apr 1, 2024
@lyzx2001 @imalasong
lightning: remove error check in TestAdjustBlockSize (pingcap#52278)
a3b8eb4 
close pingcap#52277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyzx2001 lyzx2001

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: remove error check in TestAdjustBlockSize lyzx2001/tidb
1 participant
@lyzx2001