-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: cleanup outdate regions's memory from region-cache in 2.1 #11931
Merged
sre-bot
merged 4 commits into
pingcap:release-2.1
from
lysu:de-21-cleanup-outdate-region-memory
Sep 2, 2019
Merged
tikv: cleanup outdate regions's memory from region-cache in 2.1 #11931
sre-bot
merged 4 commits into
pingcap:release-2.1
from
lysu:de-21-cleanup-outdate-region-memory
Sep 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
added
type/enhancement
The issue or PR belongs to an enhancement.
component/tikv
labels
Aug 29, 2019
LGTM |
The long-time is spent in locateing key? maybe we can also update the |
see more detail at google/btree#25
jackysp
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should we update btree in master and release-3.0? |
jackysp
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 2, 2019
/run-all-tests |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/tikv
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
current region-cache should not clean up regions out of TTL #4506
this takes the risk to leave many invalid regions in the region-cache, although
LocateKey
andgetCachedRegion
can be free lock, it will hurt theDropStoreOnFail
's performance(hold longer lock), for a long-running cluster with many regions, send tikv fail will be slow.What is changed and how it works?
to control the modification, just add clear up logic in
DropStoreOnFail
(they already hold the lock to loops all regions, so this will not introduce any other locks cost)Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is