-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: make requests fail quickly when the dial times out #12819
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12819 +/- ##
==============================================
- Coverage 80.146% 80.1011% -0.045%
==============================================
Files 465 465
Lines 107903 107398 -505
==============================================
- Hits 86480 86027 -453
Misses 14951 14951
+ Partials 6472 6420 -52 |
@coocood, @tiancaiamao, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Have you run the manual test again after the latest modification? |
@coocood I have added a new failpoint to mock the wrong addr by manually:
|
LGTM |
/run-all-tests |
/run-all-tests |
/run-all-tests |
cherry pick to release-3.1 failed |
cherry pick to release-3.0 failed |
# Conflicts: # store/tikv/client_batch.go
What problem does this PR solve?
current impl, we need wait request-timeout(cop:60s, 2pc:20s, point-get:20s) to trigger retry.
we should fail-fast if can't connect to target host, because request-timeout thinking about processing time, but for network unreachable error, it's better to timeout quickly and retry others.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is