-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb-server: handle deprecated configuration item in config-check #13142
Conversation
config-check means "check config and exit" config-strict means "enforce config file validity"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-check_dev |
Codecov Report
@@ Coverage Diff @@
## master #13142 +/- ##
==============================================
+ Coverage 80.346% 80.7511% +0.405%
==============================================
Files 469 468 -1
Lines 112283 114417 +2134
==============================================
+ Hits 90215 92393 +2178
+ Misses 15135 15134 -1
+ Partials 6933 6890 -43 |
/run-all-tests |
f238940
to
11b8006
Compare
@tiancaiamao Please update the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done @coocood |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
cherry pick to release-3.0 in PR #13272 |
cherry pick to release-3.1 in PR #13273 |
Ref #12594 |
What problem does this PR solve?
Make using tidb-ansible to rolling update TiDB smooth.
Providing that there is a "pessimistic.ttl = 40s" in the config file, before this PR:
After this PR:
What is changed and how it works?
Maintain a deprecated configure item list, if the unknown configure option belongs to the list,
return a warning instead of panic.
Check List
Tests
Side effects
Related changes