-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats: specially handle unqiue key when estimate #13354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
859e4b4
to
6d27833
Compare
Codecov Report
@@ Coverage Diff @@
## master #13354 +/- ##
================================================
- Coverage 81.8792% 80.5111% -1.3681%
================================================
Files 469 469
Lines 200273 114517 -85756
================================================
- Hits 163982 92199 -71783
+ Misses 24739 15340 -9399
+ Partials 11552 6978 -4574 |
Your auto merge job has been accepted, waiting for 13294, 13323 |
/run-all-tests |
/rebuild |
/run-all-tests |
/merge |
Your auto merge job has been accepted, waiting for 13360, 12996 |
/run-all-tests |
cherry pick to release-2.1 failed |
cherry pick to release-3.1 failed |
cherry pick to release-3.0 failed |
What problem does this PR solve?
When there are equal conditions on unique key, the estimation result should not greater than 1.
What is changed and how it works?
Take the unique info into consideration when we estimate equal conditions for indices and primary key.
Check List
Tests
Code changes
Side effects
Related changes
Release note