ddl: improve ddl test #1387
Merged
ddl: improve ddl test #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func (s *testColumnChangeSuite) SetUpSuite(c *C) { | ||
| s.store = testCreateStore(c, "test_column_change") | ||
| log.Errorf("test column change store %s", s.store.UUID()) |
|
|
||
| // RowsWithSep is a convenient function to wrap args to a slice of []interface. | ||
| // The arg represents a row, split by sep. | ||
| func RowsWithSep(sep string, args ...string) [][]interface{} { |
There was a problem hiding this comment.
This is a function with the same name and the same behavior in util/testkit/testkit.go.
There was a problem hiding this comment.
I move this from testkit to testutil to avoid dependency cycle.
|
LGTM |
| } | ||
| err := kv.RunInNewTxn(s.store, true, func(txn kv.Transaction) error { | ||
| t := meta.NewMeta(txn) | ||
| err1 := errors.Trace(t.CreateDatabase(s.dbInfo)) |
There was a problem hiding this comment.
Why not return the error directly?
|
LGTM |
3pointer
added a commit
to 3pointer/tidb
that referenced
this pull request
Aug 6, 2021
1b0e54c2f lightning: check and restore pd scheduler even if our task failed (pingcap#1336) 073d3596c lightning: fix the bug that calculate unfinished ranges may miss some range (pingcap#1413) 82ff927df backup: refine backup log for tracing backup tasks (pingcap#1335) e907562e8 lightning: make create table ddl compatible with clustered index (pingcap#1364) b6cab4b27 lightning: auto configure for parallel import (pingcap#1387) git-subtree-dir: br git-subtree-split: 1b0e54c2f2dca87bd0ad46201cbf27121e681b62
7 tasks
3pointer
added a commit
to 3pointer/tidb
that referenced
this pull request
Aug 6, 2021
3b1308e89 lightning: evaluate all generated columns even if they are virtual (pingcap#1407) 1b0e54c2f lightning: check and restore pd scheduler even if our task failed (pingcap#1336) 073d3596c lightning: fix the bug that calculate unfinished ranges may miss some range (pingcap#1413) 82ff927df backup: refine backup log for tracing backup tasks (pingcap#1335) e907562e8 lightning: make create table ddl compatible with clustered index (pingcap#1364) b6cab4b27 lightning: auto configure for parallel import (pingcap#1387) git-subtree-dir: br git-subtree-split: 3b1308e89de39325c3f0aa8931aebdf56db663f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
column_change_test.gowhich can operate schemas in different state at a given time to verify correctness.Set lease to a much smaller time so
skip_ddlflag can be removed.Following PR will add better index change test in the same way.