Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove useless HandleOverflowOnSelection #50279

Merged

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #50278

Problem Summary:

The function HandleOverflowOnSelection seems useless. It was introduced in PR #14081 to solve some bugs.

However, in PR #16014, when converting a string to bool, we use StrToFloat instead of StrToInt. StrToFloat does not raise overflow error and all other errors should be swallowed in StrToFloat when the statement is select ...

We can remove HandleOverflowOnSelection safely now.

What changed and how does it work?

Remove HandleOverflowOnSelection

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      regress the old tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #50279 (35f7a1c) into master (eaab02f) will decrease coverage by 14.6602%.
Report is 22 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50279         +/-   ##
=================================================
- Coverage   70.0660%   55.4058%   -14.6602%     
=================================================
  Files          1443       1554        +111     
  Lines        419720     586711     +166991     
=================================================
+ Hits         294081     325072      +30991     
- Misses       105346     238917     +133571     
- Partials      20293      22722       +2429     
Flag Coverage Δ
integration 36.5784% <100.0000%> (?)
unit 70.0010% <0.0000%> (-0.0650%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.5258% <ø> (+5.8465%) ⬆️

@YangKeao YangKeao self-requested a review January 11, 2024 02:19
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 07:10:52.963329937 +0000 UTC m=+513642.547583627: ☑️ agreed by qw4990.
  • 2024-01-11 09:39:36.868706796 +0000 UTC m=+522566.452960469: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot merged commit 22d2f6d into pingcap:master Jan 11, 2024
22 checks passed
@lcwangchao lcwangchao deleted the remove_HandleOverflowOnSelection branch January 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove useless function HandleOverflowOnSelection
3 participants