expression: remove useless HandleOverflowOnSelection
#50279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #50278
Problem Summary:
The function
HandleOverflowOnSelection
seems useless. It was introduced in PR #14081 to solve some bugs.However, in PR #16014, when converting a string to bool, we use
StrToFloat
instead ofStrToInt
.StrToFloat
does not raise overflow error and all other errors should be swallowed inStrToFloat
when the statement isselect ..
.We can remove
HandleOverflowOnSelection
safely now.What changed and how does it work?
Remove
HandleOverflowOnSelection
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.