Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check plan type when executing explain format="dot". (#17144) #17157

Merged
merged 9 commits into from
Jul 27, 2020
Merged

planner: check plan type when executing explain format="dot". (#17144) #17157

merged 9 commits into from
Jul 27, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #17144 to release-3.0

What problem does this PR solve?

Issue Number: close #17141

What is changed and how it works?

Check plan type when executing explain format="dot".

Check List

Tests

  • Unit test

Release note

Check plan type when executing explain format="dot".

@LittleFall @sre-bot
cherry pick pingcap#17144 to release-3.0
e4170ae 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request May 13, 2020
Merged
@sre-bot sre-bot added this to the v3.0.14 milestone May 13, 2020
zz-jason
zz-jason reviewed May 13, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LittleFall please resolve conflict and fix CI.

@LittleFall
Copy link
Contributor

/build

@LittleFall
Copy link
Contributor

/run-unit-test

@LittleFall
Copy link
Contributor

/run-check_dev

@LittleFall
Copy link
Contributor

/build

@bb7133 bb7133 modified the milestones: v3.0.14, v3.0.15 May 19, 2020
@bb7133 bb7133 modified the milestones: v3.0.15, 3.0.16 Jun 6, 2020
@bb7133 bb7133 added this to the v3.0.16 milestone Jun 6, 2020
@qw4990
Copy link
Contributor

qw4990 commented Jun 28, 2020

/rebuild

qw4990
qw4990 reviewed Jun 28, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@qw4990,Thanks for you review.

@qw4990
Copy link
Contributor

qw4990 commented Jun 28, 2020 •
edited
Loading

Please fix the CI problem caused by TestExplainDotForExplainPlan. @LittleFall

@qw4990 qw4990 modified the milestones: v3.0.16, v3.0.17 Jun 28, 2020
LittleFall
LittleFall reviewed Jun 28, 2020
View reviewed changes
executor/explainfor_test.go Outdated Show resolved Hide resolved
executor/explainfor_test.go Outdated Show resolved Hide resolved
@LittleFall
Copy link
Contributor

Please fix the CI problem caused by TestExplainDotForExplainPlan. @LittleFall

@qw4990 I don't have permission to modify, could you modify it according to the comments above?

@winoros @LittleFall
Apply suggestions from code review
666c3e2 
Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
@winoros winoros mentioned this pull request Jul 27, 2020
Merged
@winoros
Copy link
Member

winoros commented Jul 27, 2020

./run-all-tests

XuHuaiyu
XuHuaiyu approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 27, 2020
@winoros
Copy link
Member

winoros commented Jul 27, 2020

/run-unit-test

1 similar comment
@XuHuaiyu
Copy link
Contributor

/run-unit-test

@winoros winoros merged commit 8603b8a into pingcap:release-3.0 Jul 27, 2020
@winoros winoros deleted the release-3.0-44a894de6dd7 branch July 27, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall left review comments

@qw4990 qw4990 qw4990 left review comments

@zz-jason zz-jason zz-jason left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees

@LittleFall LittleFall

Labels
sig/execution SIG execution sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.17
Development

Successfully merging this pull request may close these issues.
8 participants
@sre-bot @LittleFall @qw4990 @ti-srebot @winoros @XuHuaiyu @zz-jason @bb7133