executor: support global kill #17649

pingyu · 2020-06-03T17:39:07Z

What problem does this PR solve?

Issue Number: close #8854

Problem Summary:
Support CTRL-C or KILL to kill a connection/query.

What is changed and how it works?

Compose a global unique connection id by a unique server id and local unique connection id. See design doc for detail.

Related changes

tipb: proto/executor: add Kill executor tipb#189

Check List

Tests

Unit Test
Manual Test

[client on TiDB id:2002]

mysql root@localhost:information_schema> select * from cluster_info;                            
Reconnecting...
+------+-----------------+-----------------+--------------+------------------------------------------+---------------------------+------------------+-----------+
| TYPE | INSTANCE        | STATUS_ADDRESS  | VERSION      | GIT_HASH                                 | START_TIME                | UPTIME           | SERVER_ID |
+------+-----------------+-----------------+--------------+------------------------------------------+---------------------------+------------------+-----------+
| tidb | 127.0.0.1:4000  | 127.0.0.1:10080 | 4.0.0-beta.2 | 2fc30a6b5986e512ed7fda775c25ab7b3b38f55d | 2020-06-25T19:50:10+08:00 | 4m49.455269s     | 2001      |
| tidb | 127.0.0.1:4100  | 127.0.0.1:10180 | 4.0.0-beta.2 | 2fc30a6b5986e512ed7fda775c25ab7b3b38f55d | 2020-06-25T19:50:17+08:00 | 4m42.455272s     | 2002      |
| pd   | 127.0.0.1:2379  | 127.0.0.1:2379  | 4.1.0-alpha  | 4c132fdf9461388555facaaf994b4d0253057bf3 | 2020-06-25T17:32:16+08:00 | 2h22m43.455274s  | 0         |
| tikv | 127.0.0.1:20160 | 127.0.0.1:20180 | 4.1.0-alpha  | 4ec9476a7a4fec296c49c26feac4702a02645d54 | 2020-06-24T00:14:22+08:00 | 43h40m37.45528s  | 0         |
| tikv | 127.0.0.1:20161 | 127.0.0.1:20180 | 4.1.0-alpha  | 4ec9476a7a4fec296c49c26feac4702a02645d54 | 2020-06-24T00:14:21+08:00 | 43h40m38.455282s | 0         |
| tikv | 127.0.0.1:20162 | 127.0.0.1:20180 | 4.1.0-alpha  | 4ec9476a7a4fec296c49c26feac4702a02645d54 | 2020-06-24T00:14:21+08:00 | 43h40m38.455283s | 0         |
+------+-----------------+-----------------+--------------+------------------------------------------+---------------------------+------------------+-----------+
6 rows in set
Time: 0.016s
mysql root@localhost:information_schema> select sleep(60);                                      
+-----------+
| sleep(60) |
+-----------+
| 1         |
+-----------+
1 row in set
Time: 9.266s
mysql root@localhost:information_schema>

[client on TiDB id:2001]

mysql root@localhost:information_schema> select * from cluster_info;                                                                     
+------+-----------------+-----------------+--------------+------------------------------------------+---------------------------+------------------+-----------+
| TYPE | INSTANCE        | STATUS_ADDRESS  | VERSION      | GIT_HASH                                 | START_TIME                | UPTIME           | SERVER_ID |
+------+-----------------+-----------------+--------------+------------------------------------------+---------------------------+------------------+-----------+
| tidb | 127.0.0.1:4000  | 127.0.0.1:10080 | 4.0.0-beta.2 | 2fc30a6b5986e512ed7fda775c25ab7b3b38f55d | 2020-06-25T19:50:10+08:00 | 5m3.702615s      | 2001      |
| tidb | 127.0.0.1:4100  | 127.0.0.1:10180 | 4.0.0-beta.2 | 2fc30a6b5986e512ed7fda775c25ab7b3b38f55d | 2020-06-25T19:50:17+08:00 | 4m56.702619s     | 2002      |
| pd   | 127.0.0.1:2379  | 127.0.0.1:2379  | 4.1.0-alpha  | 4c132fdf9461388555facaaf994b4d0253057bf3 | 2020-06-25T17:32:16+08:00 | 2h22m57.70262s   | 0         |
| tikv | 127.0.0.1:20160 | 127.0.0.1:20180 | 4.1.0-alpha  | 4ec9476a7a4fec296c49c26feac4702a02645d54 | 2020-06-24T00:14:22+08:00 | 43h40m51.702622s | 0         |
| tikv | 127.0.0.1:20161 | 127.0.0.1:20180 | 4.1.0-alpha  | 4ec9476a7a4fec296c49c26feac4702a02645d54 | 2020-06-24T00:14:21+08:00 | 43h40m52.702623s | 0         |
| tikv | 127.0.0.1:20162 | 127.0.0.1:20180 | 4.1.0-alpha  | 4ec9476a7a4fec296c49c26feac4702a02645d54 | 2020-06-24T00:14:21+08:00 | 43h40m52.702626s | 0         |
+------+-----------------+-----------------+--------------+------------------------------------------+---------------------------+------------------+-----------+
6 rows in set
Time: 0.017s
mysql root@localhost:information_schema> select * from CLUSTER_PROCESSLIST                                                               
+-----------------+------------------+------+------+--------------------+---------+------+------------+-----------------------------------+-----+----------------------------------------+
| INSTANCE        | ID               | USER | HOST | DB                 | COMMAND | TIME | STATE      | INFO                              | MEM | TxnStart                               |
+-----------------+------------------+------+------+--------------------+---------+------+------------+-----------------------------------+-----+----------------------------------------+
| 127.0.0.1:10080 | 4400245534359557 | root | ::1  | information_schema | Query   | 0    | autocommit | select * from CLUSTER_PROCESSLIST | 0   | 06-25 19:55:19.366(417617967675080706) |
| 127.0.0.1:10180 | 4402444557615113 | root | ::1  | information_schema | Query   | 1    | autocommit | select sleep(60)                  | 0   |                                        |
+-----------------+------------------+------+------+--------------------+---------+------+------------+-----------------------------------+-----+----------------------------------------+
2 rows in set
Time: 0.016s
mysql root@localhost:information_schema> kill 4402444557615113;                                                                          
Query OK, 0 rows affected
Time: 0.001s
mysql root@localhost:information_schema>

Release note

Support KILL <connectionID> across the whole cluster.

sre-bot · 2020-06-03T17:39:19Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-06-06T07:38:55Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

breezewish · 2020-06-11T13:01:11Z

docs/design/2020-06-01-global-kill.md

+
+1. Extend connection ids from 32 to 64 bits would break some clients. Main current clients need to be checked for compatibility.
+
+2. Some clients would probably send `KILL` command with 32 bits connection ids. We should deal with this circumstance. (Ref. [1](https://github.com/pingcap/tidb/issues/8854#issuecomment-637217000) [2](https://github.com/pingcap/tidb/issues/8854#issuecomment-637237183))


I suggest to leave some space discuss about mysql-client Ctrl+C compatibility. We don't need to give solutions in this RFC and we will resolve it later by introducing another RFC specifically for further introducing a 32 bit global connection id for small clusters.

sre-bot · 2020-06-14T03:32:29Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-06-14T16:46:57Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

design doc

try compatibility by hacking a 64 bits connID.

breezewish · 2020-10-26T09:45:39Z

Please resolve conflicts, thanks!

pingyu · 2020-10-26T15:15:02Z

/run-all-tests

pingyu · 2020-10-27T01:26:26Z

Conflicts resolved.

idc-jenkins-ci-tidb/unit-test failed in TestClusterIndexAnalyze, which failed in master, too. It seems to be not relevant to do this PR. I'm looking for the cause.

breezewish · 2020-10-27T09:20:36Z

/merge

ti-srebot · 2020-10-27T09:20:40Z

@breeswish Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIGs: execution(slack),ddl(slack).

SunRunAway · 2020-10-27T09:37:22Z

/merge

ti-srebot · 2020-10-27T09:39:53Z

/run-all-tests

ti-srebot · 2020-10-27T09:44:57Z

@pingyu merge failed.

SunRunAway · 2020-10-27T11:19:55Z

/merge

ti-srebot · 2020-10-27T11:22:23Z

/run-all-tests

ti-srebot · 2020-10-27T11:29:20Z

@pingyu merge failed.

sre-bot added the contribution This PR is from a community contributor. label Jun 3, 2020

pingyu mentioned this pull request Jun 3, 2020

Support CTRL-C or kill <connId> to kill a connection/query by implementing global connection IDs #8854

Closed

3 tasks

pingyu force-pushed the executor_global_kill branch from 1a2eba1 to e6fdfec Compare June 6, 2020 07:38

breezewish reviewed Jun 11, 2020

View reviewed changes

pingyu force-pushed the executor_global_kill branch from e6fdfec to d69842e Compare June 14, 2020 03:32

pingyu force-pushed the executor_global_kill branch from c950e77 to a121b50 Compare June 19, 2020 15:57

pingyu requested a review from a team as a code owner June 21, 2020 16:54

pingyu requested review from qw4990 and removed request for a team June 21, 2020 16:54

github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Jun 21, 2020

pingyu added 13 commits June 25, 2020 14:05

executor: global kill

5b02402

design doc

improve design doc according to reviews

9bdcde4

improve design doc according to reviews

f2c17e6

executor: support global connection ids & kill

99024f2

try compatibility by hacking a 64 bits connID.

update

58bac9e

Update. 64 bits in this stage only

7f9cd87

update

7655ecb

update

978da61

a working version

962bfc4

fix unit test errors

d0eefb1

fix unit test

e44891f

fix unit test

83e9b7a

rebase to latest

a689113

pingyu force-pushed the executor_global_kill branch from 4c4600b to a689113 Compare June 25, 2020 06:20

fix go.sum

2fc30a6

ti-srebot previously approved these changes Oct 26, 2020

View reviewed changes

Merge branch 'master' into executor_global_kill

e893ab4

pingyu dismissed stale reviews from ti-srebot, SunRunAway, and breezewish via e893ab4 October 26, 2020 15:05

ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2020

Merge branch 'master' into executor_global_kill

5e2eca2

Merge branch 'master' into executor_global_kill

69494c6

This was referenced Oct 27, 2020

executor_test.go:testCoprCache.TestIntegrationCopCache failed #20547

Closed

infoschema_reader_test.go:inspectionSuite.TearDownSuite failed #20229

Closed

SunRunAway approved these changes Oct 27, 2020

View reviewed changes

SunRunAway merged commit 272f964 into pingcap:master Oct 27, 2020

pingyu mentioned this pull request Nov 2, 2020

executor: support global kill (32 bits) #20749

Merged

breezewish mentioned this pull request Nov 6, 2020

64bit connection id may break slow query detail pingcap/tidb-dashboard#791

Closed

kennytm mentioned this pull request Nov 14, 2020

Support Background Execution or CREATE EVENT #20848

Open

pingyu mentioned this pull request Jan 1, 2021

tidb: add doc for global kill pingcap/docs#4565

Merged

11 tasks

ti-srebot mentioned this pull request Jan 18, 2021

tidb: add doc for global kill (#4565) pingcap/docs#4646

Merged

11 tasks

xuyifangreeneyes mentioned this pull request Mar 29, 2022

domain: adjust the order of acquireServerID and GlobalInfoSyncerInit to fix global kill test #33536

Merged

12 tasks

ti-srebot mentioned this pull request Apr 26, 2022

domain: adjust the order of acquireServerID and GlobalInfoSyncerInit to fix global kill test (#33536) #34255

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor: support global kill #17649

executor: support global kill #17649

pingyu commented Jun 3, 2020 •

edited by SunRunAway

Loading

sre-bot commented Jun 3, 2020

sre-bot commented Jun 6, 2020

breezewish Jun 11, 2020

sre-bot commented Jun 14, 2020

sre-bot commented Jun 14, 2020

breezewish commented Oct 26, 2020

pingyu commented Oct 26, 2020

pingyu commented Oct 27, 2020 •

edited

Loading

breezewish commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

SunRunAway commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

SunRunAway commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

ti-srebot commented Oct 27, 2020


		1. Extend connection ids from 32 to 64 bits would break some clients. Main current clients need to be checked for compatibility.

		2. Some clients would probably send `KILL` command with 32 bits connection ids. We should deal with this circumstance. (Ref. [1](https://github.com/pingcap/tidb/issues/8854#issuecomment-637217000) [2](https://github.com/pingcap/tidb/issues/8854#issuecomment-637237183))

executor: support global kill #17649

executor: support global kill #17649

Conversation

pingyu commented Jun 3, 2020 • edited by SunRunAway Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

sre-bot commented Jun 3, 2020

sre-bot commented Jun 6, 2020

breezewish Jun 11, 2020

Choose a reason for hiding this comment

sre-bot commented Jun 14, 2020

sre-bot commented Jun 14, 2020

breezewish commented Oct 26, 2020

pingyu commented Oct 26, 2020

pingyu commented Oct 27, 2020 • edited Loading

breezewish commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

SunRunAway commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

SunRunAway commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

ti-srebot commented Oct 27, 2020

pingyu commented Jun 3, 2020 •

edited by SunRunAway

Loading

pingyu commented Oct 27, 2020 •

edited

Loading