-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: check gc safe time first when iterate the history ddl jobs (#18380) #18386
Merged
SunRunAway
merged 4 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-c13e4ab1be3e
Jul 15, 2020
Merged
executor: check gc safe time first when iterate the history ddl jobs (#18380) #18386
SunRunAway
merged 4 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-c13e4ab1be3e
Jul 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
sig/execution
SIG execution
type/3.0-cherry-pick
type/enhancement
The issue or PR belongs to an enhancement.
labels
Jul 6, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
/run-all-tests |
tangenta
reviewed
Jul 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AilinKid
reviewed
Jul 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
AilinKid
approved these changes
Jul 15, 2020
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
type/enhancement
The issue or PR belongs to an enhancement.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18380 to release-3.0
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
When requesting the
/tiflash/replica
HTTP API, it will iterate the history DDL job to find the dropped table that has not been GC.Before this PR, if the TiDB cluster has not done the
drop table
ordrop database
DDL jobs, the/tiflash/replica
HTTP API will iterate all DDL jobs, it would be very slow when there are many history DDL jobs.How to avoid this problem before this PR?
You can simply create a random table and then drop it, then after the GC safe time passed, then request the
/tiflash/replica
HTTP API will be normal speed.What is changed and how it works?
check gc safe time first when iterate the history ddl jobs.
Related changes
Check List
Tests
Side effects
Release note
/tiflash/replica
HTTP API was slow when there are many history DDL jobs in TiDB cluster.