util: fix a encode bug causes the wrong result of hashJoin with set and enum #18855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhuang2016
added
priority/release-blocker
|
LGTM |
wjhuang2016
added
needs-cherry-pick-4.0
and removed
status/LGT1
wjhuang2016
changed the title
wjhuang2016
changed the title
|
/run-all-tests |
qw4990
reviewed
Jul 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #18855 +/- ##
===========================================
Coverage 79.1969% 79.1969%
===========================================
Files 546 546
Lines 147728 147728
===========================================
Hits 116996 116996
Misses 21294 21294
Partials 9438 9438 |
ti-srebot
approved these changes
Jul 29, 2020
wjhuang2016
added
the
status/can-merge
|
@wjhuang2016 Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIGs: execution(slack). |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18859 |
zz-jason
pushed a commit
that referenced
this pull request
Jul 29, 2020
zz-jason
pushed a commit
that referenced
this pull request
Jul 29, 2020
|
@wjhuang2016 It should be cherry-picked to release-3.0 & release-3.1. |
|
/run-cherry-picker |
|
cherry pick to release-3.0 in PR #19172 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #18850
Problem Summary:
Previously, we use the offset of set or enum to decide if two sets or enum are equal, which is not always correct.
What is changed and how it works?
What's Changed:
When encode set or enum, use the offset to get the original string
Related changes
Check List
Tests
Side effects
Release note