-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix error tikv_cop_wait time in metric profile (#19859) #19881
executor: fix error tikv_cop_wait time in metric profile (#19859) #19881
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-integration-copr-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry-pick #19859 to release-4.0
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
tikv_cop_wait
metric has atype
label, it has 3 values:all
,schedule
,snapshot
. And theall total_time
=schedule total time
+snapshot total time
.What is changed and how it works?
When collecting the total time of
tikv_cop_wait
, should ignore theall
type value.Related changes
Check List
Tests
Before
This PR
Side effects
Release note