Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix show table regions bug (#19562) #19895

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19562 to release-4.0


What problem does this PR solve?

close: pingcap/br#477
Problem Summary:
when the last region has the endKey is as same as the range endKey. show table regions will return ERROR 1105 (HY000): PD returned no region error

What is changed and how it works?

What's Changed:

break when last scan region has same endkey with range endKey.

How it Works:

it won't scan next round, and return immediately

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    before this commit:
    MySQL [d]> show table t1 regions; ERROR 1105 (HY000): PD returned no region

with this commit:
works well

Release note

  • Fix the issue that will raise no regions error when table range end key and region endKey are same.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@3pointer please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 9, 2020
@AilinKid
Copy link
Contributor

AilinKid commented Sep 9, 2020

/run-all-tests

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Sep 9, 2020
@AilinKid
Copy link
Contributor

AilinKid commented Sep 9, 2020

/run-all-tests

@zimulala zimulala merged commit 125258b into pingcap:release-4.0 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants