Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "*: using standard error to replace terror (#19425)" #19945

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Revert "*: using standard error to replace terror (#19425)" #19945

merged 2 commits into from
Sep 11, 2020

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Sep 11, 2020 •
edited by bobotu
Loading

Reverts #19888
Because there is some compatibility issue with binlog

Release note

  • No release note

@imtbkcat imtbkcat added the type/bugfix This PR fixes a bug. label Sep 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@bobotu
Copy link
Contributor

bobotu commented Sep 11, 2020

/rebuild

bobotu
bobotu reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@bobotu,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIGs: execution(slack),ddl(slack).

@lysu
Copy link
Contributor

lysu commented Sep 11, 2020

/approve

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2020
@ti-srebot
Copy link
Contributor

@jebter,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIGs: execution(slack),ddl(slack).

@jebter
Copy link

jebter commented Sep 11, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 11, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 51d365f into release-4.0 Sep 11, 2020
@ti-srebot ti-srebot deleted the revert-19888-release-4.0-449587a08548 branch September 11, 2020 06:32
@joncodo joncodo mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobotu bobotu bobotu left review comments

@jebter jebter jebter approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@imtbkcat @sre-bot @bobotu @ti-srebot @lysu @jebter