planner: the issue that incorrect result is returned for indeterministic function when executing a prepared point-get update. #21883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
bb7133
force-pushed
the
bb7133/try_validate
branch
from
f934fd1
to
c6e5686
Compare
|
/run-all-tests |
bb7133
force-pushed
the
bb7133/try_validate
branch
from
c6e5686
to
91bbcb8
Compare
bb7133
changed the title
|
/run-all-tests |
|
/bench |
|
LGTM |
ti-srebot
approved these changes
Dec 19, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
bb7133
added a commit
to bb7133/tidb
that referenced
this pull request
Dec 29, 2020
…tic function when executing a prepared point-get update. (pingcap#21883)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #21884
Problem Summary:
In #12243, the evaluated value of the parameters of the prepared statement is improperly cached in
tryCachePointPlan, which caused the bug reported in #21884 :tidb/planner/core/common_plans.go
Line 405 in 91bbcb8
What is changed and how it works?
How it Works:
Commented the related caching codes in
tryCachePointPlanas a short-term solution, the fix will be refined in the future.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note