Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix visit info for grant/revoke #23946

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Apr 11, 2021

What problem does this PR solve?

Problem Summary:

Fixes #24142 and fixes #24143

There are a few bugs with visitInfo and REVOKE/GRANT:

  • Revoke on a dynamic privilege should require the "grant option" of the dynamic privilege. If there are only dynamic privileges being revoked, it should not require the global grant option.
  • Revoke did not correctly populate the dynamic privilege name in visitInfo for privilege checking, it now does (grant handled this correctly.)
  • Both revoke/grant on a global basis populated the DB Name from the session, which is incorrect meta data. Tests for visitInfo on GRANT ALL / REVOKE ALL have been added, and show correct data.

What is changed and how it works?

See above.

Related changes

  • None

Check List

Tests

  • Unit test

Side effects

  • None

Release note

  • The privilege checking of GRANT and REVOKE statements has been improved.

@morgo morgo requested a review from a team as a code owner April 11, 2021 20:08
@morgo morgo requested review from winoros and removed request for a team April 11, 2021 20:08
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2021
@morgo morgo requested a review from tiancaiamao April 11, 2021 20:09
@morgo morgo added sig/sql-infra SIG: SQL Infra sig/planner SIG: Planner labels Apr 11, 2021
@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
@bb7133
Copy link
Member

bb7133 commented Apr 26, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2021
@bb7133
Copy link
Member

bb7133 commented Apr 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b32c4b0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot
Copy link
Member

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor Author

morgo commented Apr 26, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit d9e2bd3 into pingcap:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
4 participants