Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix unstable TestDropPartitionStats test #23968

Closed
wants to merge 10 commits into from
Closed

statistics: fix unstable TestDropPartitionStats test #23968

wants to merge 10 commits into from

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented Apr 12, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: part of #23967

Problem Summary:

From the error message, the reason for the error is that the test environment in the race test conflicts and the root cause is that the test environment in the race test is not isolated.

For TestDropPartitionStats, we need environmental isolation. But executor/testSerialSuite doesn't support it. So I move TestDropPartitionStats in statistics/testStatsSuite, this test suite guarantees environmental isolation.

Check List

Tests

  • Unit test

Release note

  • No release note

@rebelice rebelice requested review from a team as code owners April 12, 2021 11:25
@rebelice rebelice requested review from wshwsh12 and lzmhhh123 and removed request for a team April 12, 2021 11:25
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 12, 2021
@rebelice
Copy link
Contributor Author

/cc @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 April 12, 2021 11:26
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@rebelice rebelice mentioned this pull request Apr 12, 2021
Open
4 tasks
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Apr 12, 2021
@rebelice
Copy link
Contributor Author

/run-unit-test

eurekaka
eurekaka reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain why the test would fail occasionally and how the change can fix it?

@rebelice rebelice mentioned this pull request Apr 15, 2021
Open
@rebelice
Copy link
Contributor Author

Could you please explain why the test would fail occasionally and how the change can fix it?

@eurekaka I have updated the relevant information in the description

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2021
@qw4990
Copy link
Contributor

qw4990 commented Apr 15, 2021

Please resolve conflicts @rebelice

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2021
@qw4990
Copy link
Contributor

qw4990 commented Apr 27, 2021

@rebelice Please go on to promote this PR~

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2021
@wshwsh12 wshwsh12 removed their request for review June 4, 2021 08:34
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2021
@ti-chi-bot
Copy link
Member

@rebelice: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzmhhh123 lzmhhh123 removed their request for review June 15, 2021 05:50
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@hawkingrei: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

I think it can be closed. we cannot see this unstable test case for a long time.

@hawkingrei hawkingrei closed this Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rebelice @ti-srebot @ti-chi-bot @qw4990 @hawkingrei @eurekaka