-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/design: update proposal workflow #23999
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Co-authored-by: Jian Zhang <zjsariel@gmail.com>
Co-authored-by: Jian Zhang <zjsariel@gmail.com>
|
||
Although there is no single way to prepare for submitting a design document, it is generally a good idea to pursue feedback from other project developers beforehand, to ascertain that the design document may be desirable; having a consistent impact on the project requires concerted effort toward consensus-building. | ||
|
||
The most common preparations for writing and submitting an design document for now is [creating a disucss issue](https://github.com/pingcap/tidb/issues/new/choose), which is going to be converted into a tracking issue of the design implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leverage GitHub Discussion / Mailing List / Forum / Slack later when we have an active and clear communication way. I can image the discuss issue would quickly vanish from the first page of our issue view. But we don't have a better open way yet.
33441de
to
86c3d20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @bb7133 |
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
@bb7133 thanks for your review! updated. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6bf30ab
|
@tisonkun: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
What problem does this PR solve?
Issue Number: close pingcap/community#431
Problem Summary:
We'd better clarify our proposal workflow so that contributors can follow the lightweight workflow proposing features against TiDB projects, as well as improve major changes visibility.
It mainly follow tikv/rfcs which already satisfies most of our development requirement. And it is not a new workflow but formalizes best practice we already took but not yet publicly documented.
Details in files changed. Please comment against the diff.
Release note