store/tikv: fix misuse of PD client's GetStore (#23695) #24499
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #23695 to release-3.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24499
After apply modifications, you can push your change to this PR via:
Signed-off-by: longfangsong longfangsong@icloud.com
What problem does this PR solve?
Issue Number: close #23676
Problem Summary:
GetStore()
, which may result in dead loops.store.State
isn't changed if it becomes a tombstoneWhat is changed and how it works?
What's Changed:
Skip the early-return
if
branch when "load Store from PD success but pd didn't found the store"How it Works:
By checking the error message. This is a quick and dirty solution. A better solution (which needs to change the pdClient, and maybe the whole way of our error handling process) needs more discussion.
Related changes
Needs to cherry-pick to 5.0.
Check List
Tests
Release note