-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: improve TopSQL reporter memory efficiency (#25195) #25363
util: improve TopSQL reporter memory efficiency (#25195) #25363
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@dragonly please accept the invitation then you can push to the cherry-pick pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@breeswish: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@zhouqiang-cl Please help run merge, thanks a lot! |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c13076c
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
cherry-pick #25195 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25363
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
The current TopSQL reporter copies data before sending to gRPC endpoint.
What is changed and how it works?
What's Changed:
Iterate data at send time to reduce a memory copy.
How it Works:
Because the SQL/plan meta could be > 1M for each record, this could potentially save some GB of memory.
Related changes
Check List
Tests
Side effects
None.
Release note