Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: migrate test-infra to testify for planner/core/plan_to_pb_test.go #28452

Merged
merged 3 commits into from
Oct 8, 2021
Merged

planner/core: migrate test-infra to testify for planner/core/plan_to_pb_test.go #28452

merged 3 commits into from
Oct 8, 2021

Conversation

sankalp-r
Copy link
Contributor

Signed-off-by: Sankalp Rangare sankalprangare786@gmail.com

What problem does this PR solve?

Issue Number: close #28391

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 28, 2021
@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 28, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 28, 2021
@ti-chi-bot
Copy link
Member

Welcome @sankalp-r!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sankalp-r
migrate TestColumnToProto to testify
4c48811 
Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
@sankalp-r
Copy link
Contributor Author

/cc @tisonkun

tisonkun
tisonkun reviewed Sep 28, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Thanks for your contribution!

planner/core/plan_to_pb_test.go Outdated Show resolved Hide resolved
@sankalp-r @tisonkun
Update planner/core/plan_to_pb_test.go
e2c7394 
Co-authored-by: tison <wander4096@gmail.com>
tisonkun
tisonkun approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

/cc @rebelice

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2021
@rebelice
Copy link
Contributor

rebelice commented Oct 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e2c7394

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2021
@ti-chi-bot
Copy link
Member

@sankalp-r: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a9a3b3c into pingcap:master Oct 8, 2021
@sankalp-r sankalp-r deleted the migrate-TestColumnToProto branch October 8, 2021 05:14
xiongjiwei
xiongjiwei reviewed Nov 1, 2021
View reviewed changes
planner/core/plan_to_pb_test.go
func (s *testDistsqlSuite) TestColumnToProto(c *C) {
defer testleak.AfterTest(c)()
func TestColumnToProto(t *testing.T) {
t.Parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see #29125 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei left review comments

@rebelice rebelice rebelice approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for planner/core/plan_to_pb_test.go
7 participants
@sankalp-r @ti-chi-bot @CLAassistant @rebelice @tisonkun @xiongjiwei @ti-srebot