Pass go tool vet --shadow #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check for shadowed variables
|
LGTM |
1 similar comment
|
LGTM |
spongedu
pushed a commit
to spongedu/tidb
that referenced
this pull request
Oct 26, 2019
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Oct 29, 2020
support password expired
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* reset ts before starting to restore Signed-off-by: 5kbpers <tangminghua@pingcap.com> * address comments Signed-off-by: 5kbpers <tangminghua@pingcap.com> * address comments Signed-off-by: 5kbpers <tangminghua@pingcap.com> * change tso to string Signed-off-by: 5kbpers <tangminghua@pingcap.com> * *: go mod tidy Signed-off-by: 5kbpers <tangminghua@pingcap.com>
12 tasks
Defined2014
pushed a commit
to Defined2014/tidb
that referenced
this pull request
Apr 11, 2022
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
* init * audit: init first version of audit log * audit: support log global rotate * audit: update log keys * audit: more common notify implement * audit: add record id * audit: rename some names * audit: default use normal log path * audit: add server ip info * audit: do some refine * audit: Add some log keys * audit: update some item format * audit: add stmt demo * audit: support redact * audit: fix bug * audit: update filter * audit: update filter * audit: check user * audit: update * update * audit: update * audit: fix bug * aduit: update * audit: update * update * update * audit: add filter unit test * fmt * Add tests for `tidb_audit_enabled` and `tidb_audit_log` * Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime` * Add tests for `tidb_audit_log_reserved_*` * TODO: TestAuditLogRedact * Fininsh `TestAuditLogRedact` * Update (pingcap#1) * fix typo (pingcap#2) * Add `TRANSACTION` * rename sysvar * audit_log_create_filter, audit_log_remove_filter * finish function call and table test * test privilege * finish test for sysvar * TODO: TestConnectionEvenClass * update * audit: fix lint for audit log (pingcap#1) * audit: fix UT failure caused by the change of redact log (pingcap#3) * audit: use `t.TempDir()` to make test stable (pingcap#4) * audit: fix test failed for 7.1 * Add `OWNERS` file (pingcap#35) Co-authored-by: Chao Wang <cclcwangchao@hotmail.com> * audit: fix panic when logging sometime (pingcap#26) (pingcap#31) * test: fix unstable test TestAuditLogReservedDays (pingcap#8) * Format sysvar_test.go * audit: use `StatementContext` to generate redacted SQL (pingcap#9) * audit: fix panic when logging sometime (pingcap#26) * update * add owner * Update OWNERS --------- Co-authored-by: CbcWestwolf <1004626265@qq.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> * audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39) * This is an automated cherry-pick of pingcap#37 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflict --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: 王超 <cclcwangchao@hotmail.com> * extension/audit: introduce serverless audit log Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * update bazel config Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * support enable audit log when activate Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * add gwconnid to audit log Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * comment unstable test * update bazel * add log about activate request * diff audit log enabled * audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45) * This is an automated cherry-pick of pingcap#44 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Update util.go --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: 王超 <cclcwangchao@hotmail.com> * Update extension/serverless/OWNERS --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> Co-authored-by: Chao Wang <cclcwangchao@hotmail.com> Co-authored-by: cbcwestwolf <1004626265@qq.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: Yuqing Bai <baiyuq@gmail.com>
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
Co-authored-by: rishabh_mittal <mittalrishabh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove all shadow declarations