-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codec: Don't convert set or enum datum to float64 when encoding them (#32308) #32352
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
Signed-off-by: ekexium <ekexium@gmail.com>
f8b94c0
to
4c6bb0a
Compare
Signed-off-by: ekexium <ekexium@gmail.com>
dbe6d56
to
8fd7887
Compare
/run-check_dev |
1 similar comment
/run-check_dev |
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #32308 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/32352
After apply modifications, you can push your change to this PR via:
Signed-off-by: ekexium ekexium@gmail.com
What problem does this PR solve?
Issue Number: close #32302
Problem Summary:
When a enum or a set datum is encoded, it's uint64 value is converted to float64 and then converted back to uint64, resulting in the loss of lower bits.
What is changed and how it works?
Use the original
Value
, don't convert.Check List
Tests
Side effects
Documentation
Release note