Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix TestDDLSchedulingMultiTimes and TestConcurrentDDLSwitch timeout #37043

Merged
merged 5 commits into from
Aug 11, 2022
Merged

test: fix TestDDLSchedulingMultiTimes and TestConcurrentDDLSwitch timeout #37043

merged 5 commits into from
Aug 11, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Aug 11, 2022 •
edited
Loading

Signed-off-by: xiongjiwei xiongjiwei1996@outlook.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xiongjiwei
save time
aca420c 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2022
@xiongjiwei xiongjiwei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 11, 2022
@xiongjiwei
save time
90f1a50 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2022
wjhuang2016
wjhuang2016 reviewed Aug 11, 2022
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestConcurrentDDLSwitch timeouts too.

@sre-bot
Copy link
Contributor

sre-bot commented Aug 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c5287904dc6afeb104cd928bd723795db4776636

@xiongjiwei
save time
1b33f8e 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2022
@wjhuang2016
Copy link
Member

/run-test-gotest_in_verify_ci

@wjhuang2016
Copy link
Member

/run-test-tidb_integration_test_ci_shdadow_debug

@wjhuang2016
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1b33f8e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2022
@xiongjiwei xiongjiwei changed the title test: fix TestDDLSchedulingMultiTimes timeout test: fix TestDDLSchedulingMultiTimes and TestConcurrentDDLSwitch timeout Aug 11, 2022
@ti-chi-bot
Copy link
Member

@xiongjiwei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ce41ce0 into pingcap:master Aug 11, 2022
@xiongjiwei xiongjiwei deleted the testDDLScheduling branch August 11, 2022 08:21
morgo added a commit to morgo/tidb that referenced this pull request Aug 11, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-sysvar-co…
d71b97f 
…verage

* upstream/master: (98 commits)
  planner: provide a unified interface to set and get user variables and types (pingcap#37046)
  *: fix check-2 to bazel (pingcap#37055)
  distsql: revert 37019 (pingcap#37048)
  planner: introduce new functions for the general statement in session interface (pingcap#37024)
  session: make BenchmarkCompileExecutePreparedStmt update to date (pingcap#36960)
  server: Change proxyprotocol to lazy mode (pingcap#36301)
  test: fix `TestDDLSchedulingMultiTimes` and `TestConcurrentDDLSwitch` timeout (pingcap#37043)
  makefile: add bazel realtikvtest (pingcap#37042)
  distsql: make analyze request SI (pingcap#37019)
  *: gofmt code for adapting go 1.19 (pingcap#36832)
  planner: fix data race in the TestInlineProjection4HashJoinIssue15316 (pingcap#37014)
  planner: introduce Session.CacheGeneralStmt for general plan cache (pingcap#37028)
  server: revise scheme code (pingcap#37021)
  planner: fix unstable test TestPushDownSelectionForMPP (pingcap#37038)
  executor: more precise memory tracking (pingcap#35785)
  executor: add privilege check for prepare stmt (pingcap#36933)
  *: optimize temptable.SessionSnapshotInterceptor (pingcap#36999)
  statistics: batch insert topn and buckets to storage to speed up loading stats (pingcap#36948)
  planner: remove keyword `prepared` in plan cache backend (pingcap#37023)
  util: fix unstable test TestCheckCN (pingcap#37016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongjiwei @ti-chi-bot @sre-bot @wjhuang2016 @hawkingrei