txn: Fix data race of checking and exiting fair locking concurrently in LockKeys #42635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
ti-chi-bot
added
do-not-merge/work-in-progress
ti-chi-bot
removed
the
do-not-merge/work-in-progress
MyonKeminta
requested review from
you06,
cfzjywxk,
zyguan and
ekexium
and removed request for
you06
cfzjywxk
approved these changes
Mar 28, 2023
ekexium
approved these changes
Mar 28, 2023
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: af1eefb
|
ti-chi-bot
added
the
status/can-merge
|
/test unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #42615
Requires: tikv/client-go#749
Problem Summary:
The
LockKeysfunctions in txn_driver.go can be called concurrently in some case. However we added some fair locking related logic here, which is not protected by the mutex that's locked inLockKeysof client-go: if locking more than one key, exit fair locking mode.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Release note not needed since the bug is just introduced in 7.0