Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import into: fix some subtask keeps running on cancel when triggered disk quota #45049

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #45048

Problem Summary:

What is changed and how it works?

  • use parent ctx, not background

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)

    • add a block(a select with ctx.Done and time.After) at end of ProcessChunk, add a block in FlushAllEngines too, change disk quota = 1. then start import, when it block, cancel the job
    • check we can receive context.Cancelled when calling FlushAllEngines in disk quota routine
      9ac62674-d7db-4f94-903e-30259358c04d
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2023
@tiprow
Copy link

tiprow bot commented Jun 29, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-29 06:27:34.435042572 +0000 UTC m=+861819.836293015: ☑️ agreed by GMHDBJD.
  • 2023-06-29 08:13:23.703802867 +0000 UTC m=+868169.105053342: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit b6caf7b into master Jun 29, 2023
@ti-chi-bot ti-chi-bot bot deleted the fix-cancel-keepsrun branch June 29, 2023 08:14
D3Hunter added a commit that referenced this pull request Jun 30, 2023
D3Hunter added a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import into: some subtask keeps running when task cancelled
3 participants