lightning: init client-go global cfg #45464

D3Hunter · 2023-07-19T06:27:17Z

What problem does this PR solve?

Issue Number: close #45462

Problem Summary:

What is changed and how it works?

init client-go global cfg

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
- tested twice on a data-set which can reproduce after init client-go global cfg, import success
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix lightning checksum report "Region is unavailable" when target cluster enabled SSL

tiprow · 2023-07-19T06:27:42Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-07-19T06:42:01Z

Codecov Report

Merging #45464 (0581feb) into master (31bca92) will increase coverage by 0.0168%.
The diff coverage is 80.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #45464        +/-   ##
================================================
+ Coverage   73.2544%   73.2713%   +0.0168%     
================================================
  Files          1261       1261                
  Lines        388876     388923        +47     
================================================
+ Hits         284869     284969       +100     
+ Misses        85745      85711        -34     
+ Partials      18262      18243        -19

Flag	Coverage Δ
unit	`73.2713% <80.0000%> (+0.0168%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`54.0444% <ø> (ø)`
parser	`85.0899% <ø> (ø)`
br	`52.1132% <80.0000%> (+0.0390%)`	⬆️

lance6716

rest lgtm

lance6716 · 2023-07-19T07:15:22Z

br/pkg/lightning/importer/import.go

+// and the SSL error seems affects normal logic of newer TiKV version, and cause the error "tikv: region is unavailable"
+// during checksum.
+// todo: DM relay on lightning physical mode too, but client-go doesn't support passing TLS data as bytes,
+func initGlobalConfig(secCfg tikvconfig.Security) {


Can we move it to an earlier place? I'm not sure where's the first usage of tikv client.

GMHDBJD

LGTM

lance6716 · 2023-07-19T07:47:07Z

/lgtm

lance6716 · 2023-07-19T07:47:10Z

/lgtm

ti-chi-bot · 2023-07-19T07:47:13Z

[LGTM Timeline notifier]

Timeline:

2023-07-19 07:16:59.220967952 +0000 UTC m=+1093910.991306666: ☑️ agreed by GMHDBJD.
2023-07-19 07:47:12.497794093 +0000 UTC m=+1095724.268132806: ☑️ agreed by lance6716.

ti-chi-bot · 2023-07-19T07:47:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2023-07-19T07:55:09Z

/test ?

ti-chi-bot · 2023-07-19T07:55:11Z

@D3Hunter: The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2023-07-19T07:55:32Z

/test pull-br-integration-test

tiprow · 2023-07-19T07:56:11Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-07-19T07:56:18Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2023-07-19T07:57:26Z

/ok-to-test

hawkingrei · 2023-07-19T07:57:34Z

/ok-to-test

hawkingrei · 2023-07-19T08:24:35Z

/retest

ti-chi-bot · 2023-07-19T08:30:05Z

In response to a cherrypick label: new pull request created to branch release-6.5: #45466.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2023-07-19T08:30:50Z

In response to a cherrypick label: new pull request created to branch release-7.1: #45467.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

close #45462

D3Hunter added 2 commits July 19, 2023 11:18

init global config

9773080

bazel

6472ae4

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2023

ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Jul 19, 2023

niubell requested review from lance6716 and GMHDBJD July 19, 2023 07:07

lance6716 reviewed Jul 19, 2023

View reviewed changes

GMHDBJD approved these changes Jul 19, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 19, 2023

fix comments

0581feb

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 19, 2023

ti-chi-bot bot merged commit 5b8a14a into master Jul 19, 2023

ti-chi-bot bot deleted the lit-init-global-cfg branch July 19, 2023 08:29

ti-chi-bot mentioned this pull request Jul 19, 2023

lightning: init client-go global cfg (#45464) #45466

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 19, 2023

This is an automated cherry-pick of pingcap#45464

96a425d

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 19, 2023

lightning: init client-go global cfg (#45464) #45467

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 19, 2023

This is an automated cherry-pick of pingcap#45464

d7d501e

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot bot pushed a commit that referenced this pull request Jul 19, 2023

lightning: init client-go global cfg (#45464) (#45466)

ff1f933

close #45462

ti-chi-bot bot pushed a commit that referenced this pull request Jul 19, 2023

lightning: init client-go global cfg (#45464) (#45467)

cf44157

close #45462

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lightning: init client-go global cfg #45464

lightning: init client-go global cfg #45464

D3Hunter commented Jul 19, 2023

tiprow bot commented Jul 19, 2023

codecov bot commented Jul 19, 2023 •

edited

Loading

lance6716 left a comment

lance6716 Jul 19, 2023

D3Hunter Jul 19, 2023

GMHDBJD left a comment

lance6716 commented Jul 19, 2023

lance6716 commented Jul 19, 2023

ti-chi-bot bot commented Jul 19, 2023

ti-chi-bot bot commented Jul 19, 2023

D3Hunter commented Jul 19, 2023

ti-chi-bot bot commented Jul 19, 2023

D3Hunter commented Jul 19, 2023

tiprow bot commented Jul 19, 2023

tiprow bot commented Jul 19, 2023

D3Hunter commented Jul 19, 2023

hawkingrei commented Jul 19, 2023

hawkingrei commented Jul 19, 2023

ti-chi-bot commented Jul 19, 2023

ti-chi-bot commented Jul 19, 2023

lightning: init client-go global cfg #45464

lightning: init client-go global cfg #45464

Conversation

D3Hunter commented Jul 19, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Jul 19, 2023

codecov bot commented Jul 19, 2023 • edited Loading

Codecov Report

lance6716 left a comment

Choose a reason for hiding this comment

lance6716 Jul 19, 2023

Choose a reason for hiding this comment

D3Hunter Jul 19, 2023

Choose a reason for hiding this comment

GMHDBJD left a comment

Choose a reason for hiding this comment

lance6716 commented Jul 19, 2023

lance6716 commented Jul 19, 2023

ti-chi-bot bot commented Jul 19, 2023

[LGTM Timeline notifier]

ti-chi-bot bot commented Jul 19, 2023

D3Hunter commented Jul 19, 2023

ti-chi-bot bot commented Jul 19, 2023

D3Hunter commented Jul 19, 2023

tiprow bot commented Jul 19, 2023

tiprow bot commented Jul 19, 2023

D3Hunter commented Jul 19, 2023

hawkingrei commented Jul 19, 2023

hawkingrei commented Jul 19, 2023

ti-chi-bot commented Jul 19, 2023

ti-chi-bot commented Jul 19, 2023

codecov bot commented Jul 19, 2023 •

edited

Loading