-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: disable fast reorg and dist task execution for system tables #49542
ddl: disable fast reorg and dist task execution for system tables #49542
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49542 +/- ##
================================================
+ Coverage 71.0009% 71.5146% +0.5137%
================================================
Files 1368 1418 +50
Lines 399478 415758 +16280
================================================
+ Hits 283633 297328 +13695
- Misses 96044 99627 +3583
+ Partials 19801 18803 -998
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@zimulala: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ywqzzy, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #49506
Problem Summary:
When fast reorg is enabled, TiDB will check available space on temp-dir. This behavior is also applicable in upgrade scenario, and results in failure when there is no space, affecting user experience.
What changed and how does it work?
This PR disables fast reorg and dist task execution for system tables.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.