Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: disable fast reorg and dist task execution for system tables #49542

Merged
merged 8 commits into from
Dec 18, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Dec 18, 2023

What problem does this PR solve?

Issue Number: close #49506

Problem Summary:

When fast reorg is enabled, TiDB will check available space on temp-dir. This behavior is also applicable in upgrade scenario, and results in failure when there is no space, affecting user experience.

What changed and how does it work?

This PR disables fast reorg and dist task execution for system tables.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. do-not-merge/needs-tests-checked needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
Copy link

tiprow bot commented Dec 18, 2023

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #49542 (1842c80) into master (3a7bd53) will increase coverage by 0.5137%.
Report is 6 commits behind head on master.
The diff coverage is 63.3333%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49542        +/-   ##
================================================
+ Coverage   71.0009%   71.5146%   +0.5137%     
================================================
  Files          1368       1418        +50     
  Lines        399478     415758     +16280     
================================================
+ Hits         283633     297328     +13695     
- Misses        96044      99627      +3583     
+ Partials      19801      18803       -998     
Flag Coverage Δ
integration 43.6551% <63.3333%> (?)
unit 71.0005% <ø> (-0.0004%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.7603% <ø> (-5.1346%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Dec 18, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2023
zimulala
zimulala previously approved these changes Dec 18, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2023
@tangenta tangenta dismissed zimulala’s stale review December 18, 2023 09:36

Changed disable condition

@ti-chi-bot ti-chi-bot bot removed the approved label Dec 18, 2023
@tangenta tangenta changed the title ddl: disable fast reorg before running upgrading DDL ddl: disable fast reorg and dist task execution for system tables Dec 18, 2023
@ti-chi-bot ti-chi-bot bot added the approved label Dec 18, 2023
Copy link

ti-chi-bot bot commented Dec 18, 2023

@zimulala: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ywqzzy, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2023
Copy link

ti-chi-bot bot commented Dec 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-18 06:54:11.794889784 +0000 UTC m=+857542.832116709: ☑️ agreed by zimulala.
  • 2023-12-18 09:47:32.351638917 +0000 UTC m=+867943.388865844: ☑️ agreed by ywqzzy.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8ed0d47 into pingcap:master Dec 18, 2023
15 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49561.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49562.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 18, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap failed when there is no space left on temp-dir
4 participants